Add missing return type for firestore.client() by wliumelb · Pull Request #747 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
Add missing return type for firestore.client()#747
lahirumaramba merged 2 commits intofirebase:masterfrom
wliumelb:master
Add missing return type for firestore.client()#747
lahirumaramba merged 2 commits intofirebase:masterfrom
wliumelb:master
Conversation
Copy link Copy Markdown
Contributor
wliumelb
commented
Dec 15, 2023
wliumelb
commented
firestore.client() should have return type google.cloud.firestore.Client
wliumelb and others added 2 commits
December 16, 2023 01:18firestore.client() should have return type google.cloud.firestore.Client
lahirumaramba approved these changes Dec 20, 2023
Copy link Copy Markdown
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
lahirumaramba
merged commit
3c39186
into
firebase:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants