[chore] Rename pytest teardown methods from deprecated `teardown` to `teardown_method` by jonathanedey · Pull Request #768 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
[chore] Rename pytest teardown methods from deprecated teardown to teardown_method#768
jonathanedey merged 1 commit intomasterfrom
[chore] Rename pytest teardown methods from deprecated teardown to teardown_method#768
jonathanedey merged 1 commit intomasterfrom
Conversation
Copy link Copy Markdown
Collaborator
jonathanedey
commented
Feb 13, 2024
jonathanedey
commented
-
teardowndeprecation warning is now an error in pytest 8.0.0 -
Renamed to suggested
teardown_method
…`teardown_method`
jonathanedey
requested a review
from lahirumaramba
jonathanedey
assigned
lahirumaramba
jonathanedey
marked this pull request as ready for review
lahirumaramba approved these changes Feb 13, 2024
Copy link Copy Markdown
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
lahirumaramba
assigned
jonathanedey and unassigned
lahirumaramba
jonathanedey
merged commit
0752992
into
master
jonathanedey
deleted the
je-teardown
branch
jonathanedey added a commit that referenced this pull request
Feb 13, 2024…`teardown_method` (#768)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants