fix(auth): Setting httpTimeout on certificate fetch requests by hiranya911 · Pull Request #538 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
fix(auth): Setting httpTimeout on certificate fetch requests#538
hiranya911 merged 2 commits intomasterfrom
fix(auth): Setting httpTimeout on certificate fetch requests#538
hiranya911 merged 2 commits intomasterfrom
Conversation
Copy link Copy Markdown
Contributor
hiranya911
commented
Mar 23, 2021
hiranya911
commented
Passing the httpTimeout option to the request instance used to fetch public key certificates by verify_id_token() and verify_session_cookie() APIs.
Resolves #535
hiranya911 added 2 commits
March 23, 2021 16:09
hiranya911
requested a review
from lahirumaramba
hiranya911
assigned
lahirumaramba
lahirumaramba approved these changes Mar 25, 2021
Copy link Copy Markdown
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lahirumaramba
assigned
hiranya911 and unassigned
lahirumaramba
hiranya911
merged commit
5e88d92
into
master
hiranya911
deleted the
hkj-cert-timeout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants