fix(auth): Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method by pragatimodi · Pull Request #643 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
Conversation
Copy link Copy Markdown
Contributor
Changing the key value "MemoryCost" returned from standard_scrypt to "cpuMemCost"
RELEASE NOTE: Fixed an incorrect key used to set memory_cost config in auth.UserImportHash.standard_scrypt() API.
pragatimodi added 2 commits
September 8, 2022 14:02RELEASE NOTE: Fixed an incorrect key used to set MemoryCost config in standard_scrypt() API
prameshj approved these changes Sep 8, 2022
firebase_admin/_user_import.py
Outdated
Show resolved
Hide resolved
firebase_admin/_user_import.py Outdated Show resolved Hide resolved
Copy link Copy Markdown
prameshj
commented
Sep 8, 2022
prameshj commented
Sep 8, 2022Can you fix the PR description? I think bug fix 489 is referring to a github issue in a different repo?
pragatimodi
changed the title
Bug fix 489
Bug fix - Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method
prameshj approved these changes Sep 14, 2022
lahirumaramba approved these changes Sep 14, 2022
Copy link Copy Markdown
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
pragatimodi
merged commit
9e5b8e3
into
firebase:master
pragatimodi
deleted the
bug_fix_489
branch
lahirumaramba
added
the
release-note
label
lahirumaramba
changed the title
Bug fix - Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method
fix(auth): Changing variable from "MemoryCost" to "cpuMemCost" in standard_scrypt method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment