chore: Remove Python 3.7 from workflows by lahirumaramba · Pull Request #806 · firebase/firebase-admin-python
Navigation Menu
{{ message }}
firebase / firebase-admin-python Public
- Notifications You must be signed in to change notification settings
- Fork 352
Merged
chore: Remove Python 3.7 from workflows#806
lahirumaramba merged 2 commits intomasterfrom
chore: Remove Python 3.7 from workflows#806
lahirumaramba merged 2 commits intomasterfrom
Conversation
Copy link Copy Markdown
Member
- GCP auth libraries have dropped support for Python 3.7
- Our CIs and nightly builds are failing as a result
- Since Python 3.7 is deprecated in the SDK we are removing it from the workflows
- We will drop support for Python 3.7 in the next major release
- Additionally, skip integration tests on batch send APIs
lahirumaramba
requested a review
from jonathanedey
lahirumaramba
assigned
jonathanedey
Copy link Copy Markdown
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update setup.py
Copy link Copy Markdown
Member Author
lahirumaramba
commented
Aug 27, 2024
lahirumaramba commented
Aug 27, 2024We should also update setup.py
I think we can leave that till we officially drop 3.7 support in the next major version. This PR is just to remove the 3.7 versions from our CIs to unblock the release pipeline
jonathanedey approved these changes Aug 28, 2024
Copy link Copy Markdown
Collaborator
jonathanedey
left a comment
jonathanedey
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lahirumaramba
merged commit
b4700da
into
master
lahirumaramba
deleted the
lm-fix-nightlies
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment