fix: upgrade eslint-plugin-jsx-a11y by hyldmo · Pull Request #597 · github/eslint-plugin-github
Navigation Menu
{{ message }}
github / eslint-plugin-github Public
- Notifications You must be signed in to change notification settings
- Fork 65
Merged
manuelpuyol merged 1 commit intogithub:mainfrom
Jan 7, 2025Merged
fix: upgrade eslint-plugin-jsx-a11y#597
manuelpuyol merged 1 commit intogithub:mainfrom
fix: upgrade eslint-plugin-jsx-a11y#597
manuelpuyol merged 1 commit intogithub:mainfrom
Conversation
Copy link
Contributor
While it seems most of the configs have been updated to work with eslint 9, the dependency
eslint-plugin-github/package.json
Line 47 in 1b65401
| "eslint-plugin-jsx-a11y": "^6.7.1", |
doesn't have support for flat configs until v6.10.0.
This means that it crashes here:
| ...jsxA11yPlugin.flatConfigs.recommended, |
hyldmo
requested a review
from a team
as a code owner
hyldmo
requested a review
from manuelpuyol
Copy link
Contributor Author
hyldmo
commented
Jan 7, 2025
hyldmo commented
Jan 7, 2025A small side note I think the same versioning issue applies to eslint-plugin-import. Note: I'm using yarn, which afaik has a bit different rules on how to resolve versions
manuelpuyol approved these changes Jan 7, 2025
manuelpuyol
merged commit
4059065
into
github:main
hyldmo
deleted the
fix/eslint-plugin-jsx-a11y
branch
github-actions
bot
mentioned this pull request
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment