fix: upgrade eslint-plugin-jsx-a11y by hyldmo · Pull Request #597 · github/eslint-plugin-github

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hyldmo

Copy link

Contributor

@hyldmo hyldmo commented

Jan 7, 2025

edited

Loading

While it seems most of the configs have been updated to work with eslint 9, the dependency

"eslint-plugin-jsx-a11y": "^6.7.1",

doesn't have support for flat configs until v6.10.0.

This means that it crashes here:

...jsxA11yPlugin.flatConfigs.recommended,

@hyldmo hyldmo requested a review from a team as a code owner

January 7, 2025 00:26

@hyldmo hyldmo requested a review from manuelpuyol

January 7, 2025 00:26

@hyldmo

Copy link

Contributor Author

hyldmo commented

Jan 7, 2025

A small side note I think the same versioning issue applies to eslint-plugin-import. Note: I'm using yarn, which afaik has a bit different rules on how to resolve versions

@manuelpuyol manuelpuyol merged commit 4059065 into github:main

Jan 7, 2025

@hyldmo hyldmo deleted the fix/eslint-plugin-jsx-a11y branch

January 8, 2025 13:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelpuyol manuelpuyol manuelpuyol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyldmo @manuelpuyol