Home Original page

docs: revise docstrings for generate_signed_url by DiegoQueiroz · Pull Request #408 · googleapis/python-storage

added 3 commits

April 13, 2021 21:46
The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.
The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

@google-cla google-cla bot added the cla: yes

This human has signed the Contributor License Agreement.

label

Apr 14, 2021

@cojenco cojenco changed the title Adjusting comment for accuracy docs: revise docstrings for generate_signed_url

Apr 19, 2021

@cojenco

cojenco added a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021 
* Adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

* fix: adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

Co-authored-by: cojenco <59401799+cojenco@users.noreply.github.com>

cojenco added a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021 
* Adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

* fix: adjusting comment for accuracy

The assumed property is `signer_email` and not `service_account_email`.
In nowhere a property called `service_account_email` is read from `credentials`, but `signer_email` is.

Co-authored-by: cojenco <59401799+cojenco@users.noreply.github.com>