Home Original page

fix: raise a ValueError in BucketNotification.create() if a topic name is not set by cojenco · Pull Request #617 · googleapis/python-storage

added 2 commits

October 6, 2021 11:57

@google-cla google-cla bot added the cla: yes

This human has signed the Contributor License Agreement.

label

Oct 6, 2021

@cojenco cojenco changed the title Fix: raise a ValueError in BucketNotification.create() if a topic name is not set fix: raise a ValueError in BucketNotification.create() if a topic name is not set

Oct 6, 2021

@cojenco cojenco marked this pull request as ready for review

October 6, 2021 20:21

unforced

tritone

@cojenco cojenco added the do not merge

Indicates a pull request not ready for merge, due to either quality or timing.

label

Oct 7, 2021

@cojenco cojenco removed the do not merge

Indicates a pull request not ready for merge, due to either quality or timing.

label

Oct 11, 2021

cojenco added a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021 
…e is not set (googleapis#617)

* fix: topic name is required to create a notification. add check and tests

* revise conf tests

* fix topic formatting and remove extra validation

* blacken lint

* update docstrings

cojenco added a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021 
…e is not set (googleapis#617)

* fix: topic name is required to create a notification. add check and tests

* revise conf tests

* fix topic formatting and remove extra validation

* blacken lint

* update docstrings