ExecutionStrategyParameters now has a direct transform without a Builder by bbakerman · Pull Request #3935 · graphql-java/graphql-java
Navigation Menu
{{ message }}
graphql-java / graphql-java Public
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Merged
ExecutionStrategyParameters now has a direct transform without a Builder#3935
ExecutionStrategyParameters now has a direct transform without a Builder#3935
Conversation
Copy link
Member
bbakerman
commented
Apr 28, 2025
bbakerman
commented
This is really 1% stuff. Its debatably faster BUT it uses (slightly) less memory and thats a good thing at scale
bbakerman
added
the
performance
label
Apr 28, 2025
bbakerman
requested review from
andimarek and
dondonz
bbakerman commented Apr 28, 2025
|
|
||
| Object resolveSerialField = resolveSerialField(executionContext, dataLoaderDispatcherStrategy, newParameters); | ||
| return resolveSerialField; | ||
| return resolveSerialField(executionContext, dataLoaderDispatcherStrategy, newParameters); |
Copy link
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inlined variable
Copy link
Contributor
github-actions
bot
commented
Apr 28, 2025
github-actions bot commented
Apr 28, 2025Test Results
312 files 312 suites 55s ⏱️
3 581 tests 3 576 ✅ 5 💤 0 ❌
3 670 runs 3 665 ✅ 5 💤 0 ❌
Results for commit 3790a10.
bbakerman
mentioned this pull request
dondonz
modified the milestones:
24.x non-breaking changes and bugfixes,
25.x breaking changes,
24.0
dondonz reviewed May 14, 2025
| return currentField; | ||
| } | ||
|
|
||
| @Internal |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that it's Internal
dondonz approved these changes May 14, 2025
dondonz
deleted the
skip-builder-on-esp
branch
dondonz
mentioned this pull request
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment