More explicit nullable annotations on BatchLoader interfaces by bbakerman · Pull Request #207 · graphql-java/java-dataloader
Navigation Menu
{{ message }}
graphql-java / java-dataloader Public
- Notifications You must be signed in to change notification settings
- Fork 97
Conversation
Copy link
Member
bbakerman
commented
Jun 24, 2025
bbakerman
commented
This adds V extends @Nullable Object on the batch loader interfaces to indicate that the values can be null.
This was referenced
Jun 24, 2025bbakerman commented Jun 25, 2025
| private boolean isMappedPublisher() { | ||
| return batchLoadFunction instanceof MappedBatchPublisher; | ||
| return batchLoadFunction instanceof MappedBatchPublisher || batchLoadFunction instanceof MappedBatchPublisherWithContext; | ||
| } |
Copy link
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes needs to be done again with more systemic testing MappedBatchPublisherWithContext and BatchPublisherWithContext dont work right now it seems
bbakerman
added this to the
5.0.1 milestone
pdambrauskas
mentioned this pull request
bbattezzati
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant