Telemetry Metrics Configuration. by kitography · Pull Request #18186

Telemetry Metrics Configuration. by kitography · Pull Request #18186 · hashicorp/vault

 - Switch the metric counter variables to an atomic variable type
   so that we are forced to properly load/store values to it

…could be causing flakiness of other tests.

maxb mentioned this pull request

Jun 8, 2023

jasonodonnell deleted the VAULT-8784-telemetry-turn-off-on-metrics-count branch

June 8, 2023 14:03

This was referenced

Jun 8, 2023

kitography added a commit that referenced this pull request

Jun 8, 2023

* Telemetry Metrics Configuration.

* Err Shadowing Fix (woah, semgrep is cool).

* Fix TestBackend_RevokePlusTidy_Intermediate

* Add Changelog.

* Fix memory leak.  Code cleanup as suggested by Steve.

* Turn off metrics by default, breaking-change.

* Show on tidy-status before start-up.

* Fix tests

* make fmt

* Add emit metrics to periodicFunc

* Test not delivering unavailable metrics + fix.

* Better error message.

* Fixing the false-error bug.

* make fmt.

* Try to fix race issue, remove confusing comments.

* Switch metric counter variables to an atomic.Uint32

 - Switch the metric counter variables to an atomic variable type
   so that we are forced to properly load/store values to it

* Fix race-issue better by trying until the metric is sunk.

* make fmt.

* empty commit to retrigger non-race tests that all pass locally

---------

Co-authored-by: Steve Clark <steven.clark@hashicorp.com>

kitography added a commit that referenced this pull request

Jun 13, 2023

…12.x (#21092)

* Telemetry Metrics Configuration. (#18186)

* Telemetry Metrics Configuration.

* Err Shadowing Fix (woah, semgrep is cool).

* Fix TestBackend_RevokePlusTidy_Intermediate

* Add Changelog.

* Fix memory leak.  Code cleanup as suggested by Steve.

* Turn off metrics by default, breaking-change.

* Show on tidy-status before start-up.

* Fix tests

* make fmt

* Add emit metrics to periodicFunc

* Test not delivering unavailable metrics + fix.

* Better error message.

* Fixing the false-error bug.

* make fmt.

* Try to fix race issue, remove confusing comments.

* Switch metric counter variables to an atomic.Uint32

 - Switch the metric counter variables to an atomic variable type
   so that we are forced to properly load/store values to it

* Fix race-issue better by trying until the metric is sunk.

* make fmt.

* empty commit to retrigger non-race tests that all pass locally

---------

Co-authored-by: Steve Clark <steven.clark@hashicorp.com>

* Fix duplicate code due to merge conflicts doubling count.

* Remove tests for features that aren't in 1.12

---------

Co-authored-by: Steve Clark <steven.clark@hashicorp.com>