NormalizedFileNames should add prefix instead of suffix by Godin · Pull Request #1660 · jacoco/jacoco
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Merged
NormalizedFileNames should add prefix instead of suffix#1660
Godin merged 1 commit intojacoco:masterfrom
NormalizedFileNames should add prefix instead of suffix#1660
Godin merged 1 commit intojacoco:masterfrom
Conversation
Copy link Copy Markdown
Member
Otherwise it changes file extensions.
Fixes #1656
Alternatives are
- change it to handle extensions separately/explicitly
- or change its consumers to append extension after it
Godin
added
the
component: report
label
Godin
added this to the
0.8.13 milestone
Godin
self-assigned this
Godin
force-pushed
the
issue-1656
branch
from
84bc450 to
13f9956
Compare
Copy link Copy Markdown
Member Author
Godin
commented
Aug 4, 2024
Godin commented
Aug 4, 2024@marchof could you please review? imo the only missing thing here is an update of changelog, so maybe you have an idea of how this fix can be concisely described in it?
Godin
force-pushed
the
issue-1656
branch
from
13f9956 to
8ba6ff4
Compare
Godin
force-pushed
the
issue-1656
branch
from
8ba6ff4 to
0d62155
Compare
Copy link Copy Markdown
Member
marchof
commented
Aug 12, 2024
marchof commented
Aug 12, 2024@Godin What about this:
Preserve file extensions in HTML report in case of file name clashes.
Godin
force-pushed
the
issue-1656
branch
from
0d62155 to
209109d
Compare
Otherwise it changes file extensions.
Godin
force-pushed
the
issue-1656
branch
from
209109d to
045ba54
Compare
Copy link Copy Markdown
Member Author
Godin
commented
Aug 12, 2024
Godin commented
Aug 12, 2024@marchof Thank you for the idea! ❤️ I added slightly modified version of it into changelog.
Godin
marked this pull request as ready for review
Godin
enabled auto-merge (squash)
marchof approved these changes Aug 12, 2024
Godin
merged commit
d867bbc
into
jacoco:master
Godin
deleted the
issue-1656
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment