Fixing exception on unsaved file by navya9singh · Pull Request #60362 · microsoft/TypeScript
Navigation Menu
{{ message }}
microsoft / TypeScript Public
- Notifications You must be signed in to change notification settings
- Fork 13.3k
Merged
navya9singh merged 2 commits intomicrosoft:mainfrom
Nov 3, 2024Merged
Fixing exception on unsaved file#60362
navya9singh merged 2 commits intomicrosoft:mainfrom
Fixing exception on unsaved file#60362
navya9singh merged 2 commits intomicrosoft:mainfrom
Conversation
Copy link
Member
navya9singh
commented
Oct 28, 2024
navya9singh
commented
Fixes #60087. It returns no edits when paste is applied to an unsaved file.
typescript-bot
assigned
navya9singh
typescript-bot
added
Author: Team
For Milestone Bug
labels
Oct 28, 2024
navya9singh
requested a review
from andrewbranch
andrewbranch requested changes Oct 29, 2024
src/server/session.ts
Outdated
src/server/session.ts Outdated
| } | ||
| private getPasteEdits(args: protocol.GetPasteEditsRequestArgs): protocol.PasteEditsAction | undefined { | ||
| const { file, project } = this.getFileAndProject(args); | ||
| if (!this.host.fileExists(file)) return undefined; |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use isDynamicFileName instead
navya9singh
requested a review
from andrewbranch
andrewbranch approved these changes Nov 1, 2024
navya9singh
merged commit
0ec4d30
into
microsoft:main
sandersn
removed this from PR Backlog
microsoft
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.