Home Original page

http: correctly optimize debug function by targos · Pull Request #37966 · nodejs/node

@targos 

Exporting a variable that will be mutated later doesn't work.

Refs: nodejs#37937

@nodejs-github-bot added http

Issues or PRs related to the http subsystem.

needs-ci

PRs that need a full CI run.

labels

Mar 29, 2021

mcollina

addaleax

@targos targos added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 30, 2021

targos added a commit that referenced this pull request

Mar 31, 2021 
Exporting a variable that will be mutated later doesn't work.

Refs: #37937

PR-URL: #37966
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos deleted the fix-http-debug-regression branch

March 31, 2021 16:22

MylesBorins pushed a commit that referenced this pull request

Apr 4, 2021 
Exporting a variable that will be mutated later doesn't work.

Refs: #37937

PR-URL: #37966
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>