stream: pause/resume on destroyed streams should be noop by ronag · Pull Request #62557

stream: pause/resume on destroyed streams should be noop by ronag · Pull Request #62557 · nodejs/node

Open

ronag wants to merge 1 commit intonodejs:mainfrom

ronag:pause-resume-destroyed

Open

stream: pause/resume on destroyed streams should be noop#62557
ronag wants to merge 1 commit intonodejs:mainfrom
ronag:pause-resume-destroyed

Conversation

Copy link Copy Markdown

Member

ronag commented
Apr 2, 2026

No description provided.

ronag requested a review from mcollina

April 2, 2026 06:09

Copy link Copy Markdown

Collaborator

nodejs-github-bot commented
Apr 2, 2026

Review requested:

@nodejs/streams

stream: pause/resume on destroyed streams should be noop

e6edbb5

PR-URL: nodejs#62557

nodejs-github-bot added needs-ci

PRs that need a full CI run.

stream

Issues and PRs related to the stream subsystem.

labels

Apr 2, 2026

ronag force-pushed the pause-resume-destroyed branch from 142dc31 to e6edbb5 Compare

April 2, 2026 06:09

ronag requested a review from jasnell

April 2, 2026 06:11

mcollina approved these changes Apr 2, 2026

View reviewed changes

Copy link Copy Markdown

Member

mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ronag added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Apr 2, 2026

github-actions bot removed the request-ci

Add this label to start a Jenkins CI on a PR.

label

Apr 2, 2026

Copy link Copy Markdown

Collaborator

nodejs-github-bot commented
Apr 2, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72407/

Copy link Copy Markdown

codecov bot commented
Apr 2, 2026
•

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e0d2e1c) to head (e6edbb5).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62557      +/-   ##
==========================================
- Coverage   89.72%   89.71%   -0.02%     
==========================================
  Files         695      695              
  Lines      214142   214160      +18     
  Branches    41001    41008       +7     
==========================================
- Hits       192137   192125      -12     
  Misses      14078    14078              
- Partials     7927     7957      +30

Files with missing lines	Coverage Δ
lib/internal/streams/readable.js	`97.17% <100.00%> (+<0.01%)`	⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.