test: consume bodies of fetch responses to fix failing macos 20 ci by Uzlopak · Pull Request #4528 · nodejs/undici
Conversation
Consuming the bodies ensures that the tests will not fail. Plus removing tspl in encoding.js as it seems to make issues...
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status
- I have read and agreed to the Developer's Certificate of Origin
- Tested
- Benchmarked (optional)
- Documented
- Review ready
- In review
- Merge ready
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Uzlopak
changed the title
test: warmup for macos and node 20
test: consume bodies of fetch responses to fix failing macos 20 ci
This comment was marked as outdated.
This comment was marked as outdated.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
slagiewka pushed a commit to slagiewka/undici that referenced this pull request
Feb 14, 2026
…odejs#4528) * test: warmup for macos and node 20 * refactor cookies.js * maybe tspl is the culprit * eat this * cookie * fix * await the text * fix remarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters