rename _DefaultMeter & _DefaultMeterProvider to NoOp* by codeboten · Pull Request #2383 · open-telemetry/opentelemetry-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@codeboten

Copy link Copy Markdown

Contributor

Description

For consistency with the tracer, renamed the default meter and meter provider to NoOp instead.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated

@codeboten codeboten requested a review from a team

January 17, 2022 21:54

@aabmass aabmass added the Approve Public API check

This label shows that the public symbols added or changed in a PR are strictly necessary

label

Jan 18, 2022

@ocelotl ocelotl merged commit a995e17 into open-telemetry:main

Jan 18, 2022

@codeboten codeboten deleted the codeboten/noop-meter branch

January 18, 2022 18:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes

+2 more reviewers

@ocelotl ocelotl ocelotl approved these changes

@NathanielRN NathanielRN NathanielRN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approve Public API check

This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codeboten @aabmass @ocelotl @NathanielRN