Add InMemoryMetricReader to metrics SDK by aabmass · Pull Request #2540 · open-telemetry/opentelemetry-python
Navigation Menu
{{ message }}
open-telemetry / opentelemetry-python Public
- Notifications You must be signed in to change notification settings
- Fork 836
Merged
ocelotl merged 2 commits intoopen-telemetry:mainfrom
Mar 22, 2022Merged
Add InMemoryMetricReader to metrics SDK#2540
ocelotl merged 2 commits intoopen-telemetry:mainfrom
Add InMemoryMetricReader to metrics SDK#2540
ocelotl merged 2 commits intoopen-telemetry:mainfrom
Conversation
Copy link Copy Markdown
Member
aabmass
commented
Mar 18, 2022
aabmass
commented
Description
Fixes #2539
Type of change
Please delete options that are not relevant.
- New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Added unit test
Does This PR Require a Contrib Repo Change?
- No.
Checklist:
- Followed the style guidelines of this project
- Changelogs have been updated
- Unit tests have been added
- Documentation has been updated
aabmass
requested a review
from a team
aabmass
force-pushed
the
2539-in-mem-exporter
branch
from
1665eae to
24561c6
Compare
aabmass
force-pushed
the
2539-in-mem-exporter
branch
from
24561c6 to
2832f87
Compare
lzchen reviewed Mar 21, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py Show resolved Hide resolved
ocelotl reviewed Mar 22, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py Show resolved Hide resolved
Copy link Copy Markdown
Contributor
lzchen
commented
Mar 22, 2022
lzchen commented
Mar 22, 2022The only thing missing there is a timeout which you would need a background thread/coroutine for regardless.
That's a good point. We can discuss on our recommendation of how to achieve the above scenario outside of this PR.
lzchen approved these changes Mar 22, 2022
ocelotl approved these changes Mar 22, 2022
ocelotl
merged commit
95aeecc
into
open-telemetry:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment