Fix warning message for OTLP gRPC exporter mixin by ocelotl · Pull Request #2781 · open-telemetry/opentelemetry-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ocelotl

Copy link Copy Markdown

Contributor

@ocelotl ocelotl commented

Jun 24, 2022

Fixes #2780

@ocelotl ocelotl added the Skip Changelog

PRs that do not require a CHANGELOG.md entry

label

Jun 24, 2022

@ocelotl ocelotl requested a review from a team

June 24, 2022 14:50

@ocelotl ocelotl self-assigned this

Jun 24, 2022

@ocelotl ocelotl force-pushed the issue_2780 branch 3 times, most recently from a6c0d6c to b09fe25 Compare

June 24, 2022 15:46
Copy link Copy Markdown

Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding a changelog with the fix as it's user facing error messages.

@ocelotl ocelotl added the Approve Public API check

This label shows that the public symbols added or changed in a PR are strictly necessary

label

Jun 27, 2022

@ocelotl ocelotl merged commit fe26ada into open-telemetry:main

Jul 7, 2022

@ocelotl ocelotl deleted the issue_2780 branch

July 7, 2022 14:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten Awaiting requested review from codeboten

+1 more reviewer

@srikanthccv srikanthccv srikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocelotl ocelotl

Labels

Approve Public API check

This label shows that the public symbols added or changed in a PR are strictly necessary

Skip Changelog

PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong warning in exporter mixin

4 participants

@ocelotl @codeboten @lzchen @srikanthccv