Update log symbol names by ocelotl · Pull Request #2943 · open-telemetry/opentelemetry-python
Navigation Menu
{{ message }}
open-telemetry / opentelemetry-python Public
- Notifications You must be signed in to change notification settings
- Fork 834
Merged
Conversation
ocelotl
requested a review
from a team
lzchen approved these changes Sep 22, 2022
Copy link Copy Markdown
Contributor
lzchen
commented
Sep 22, 2022
lzchen commented
Sep 22, 2022@ocelotl
Why skip changelog? I think renames should be included as part of it. We already include logging related entries in the changelog despite it being experimental.
ocelotl
force-pushed
the
issue_2926
branch
from
3f22e0e to
16cc57d
Compare
Copy link Copy Markdown
Contributor Author
ocelotl
commented
Sep 26, 2022
ocelotl commented
Sep 26, 2022Done ✌️
ocelotl
self-assigned this
Copy link Copy Markdown
Member
srikanthccv
commented
Sep 28, 2022
srikanthccv commented
Sep 28, 2022@ocelotl are you planning to add the API package that includes things like LoggerProvider and Logger interfaces, and global setter and getter providers in follow-up PR(s)?
Copy link Copy Markdown
Contributor Author
ocelotl
commented
Sep 28, 2022
ocelotl commented
Sep 28, 2022@ocelotl are you planning to add the API package that includes things like
LoggerProviderandLoggerinterfaces, and global setter and getter providers in follow-up PR(s)?
sorry, which API package? I was under the impression this issue was only about renaming SDK symbols.
Copy link Copy Markdown
Member
srikanthccv
commented
Sep 28, 2022
srikanthccv commented
Sep 28, 2022Renaming is only part of it but the spec now has the logs API as well https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/logs
Copy link Copy Markdown
Contributor Author
ocelotl
commented
Sep 28, 2022
ocelotl commented
Sep 28, 2022Renaming is only part of it but the spec now has the logs API as well https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/logs
Ok, better to track this in a new issue then
srikanthccv reviewed Oct 3, 2022
CHANGELOG.md
Outdated
Show resolved
Hide resolved
ocelotl added 3 commits
October 26, 2022 20:06
ocelotl
force-pushed
the
issue_2926
branch
from
12cada0 to
31b3121
Compare
lzchen added 2 commits
October 26, 2022 12:27
lzchen
enabled auto-merge (squash)
srikanthccv approved these changes Oct 26, 2022
lzchen
merged commit
8318f01
into
open-telemetry:main
srikanthccv
mentioned this pull request
Closed
pvaneck
mentioned this pull request
jeremydvoss
mentioned this pull request
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment