Update log symbol names by ocelotl · Pull Request #2943 · open-telemetry/opentelemetry-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ocelotl

Copy link Copy Markdown

Contributor

@ocelotl ocelotl commented

Sep 21, 2022

Fixes #2926

@ocelotl ocelotl added the Skip Changelog

PRs that do not require a CHANGELOG.md entry

label

Sep 21, 2022

@ocelotl ocelotl requested a review from a team

September 21, 2022 15:16

@lzchen

Copy link Copy Markdown

Contributor

lzchen commented

Sep 22, 2022

@ocelotl
Why skip changelog? I think renames should be included as part of it. We already include logging related entries in the changelog despite it being experimental.

@ocelotl

Copy link Copy Markdown

Contributor Author

ocelotl commented

Sep 26, 2022

Done ✌️

@ocelotl ocelotl self-assigned this

Sep 26, 2022

@srikanthccv

Copy link Copy Markdown

Member

@ocelotl are you planning to add the API package that includes things like LoggerProvider and Logger interfaces, and global setter and getter providers in follow-up PR(s)?

@ocelotl

Copy link Copy Markdown

Contributor Author

ocelotl commented

Sep 28, 2022

@ocelotl are you planning to add the API package that includes things like LoggerProvider and Logger interfaces, and global setter and getter providers in follow-up PR(s)?

sorry, which API package? I was under the impression this issue was only about renaming SDK symbols.

@srikanthccv

Copy link Copy Markdown

Member

Renaming is only part of it but the spec now has the logs API as well https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/logs

@ocelotl

Copy link Copy Markdown

Contributor Author

ocelotl commented

Sep 28, 2022

Renaming is only part of it but the spec now has the logs API as well https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/logs

Ok, better to track this in a new issue then

lzchen reacted with thumbs up emoji

@lzchen lzchen enabled auto-merge (squash)

October 26, 2022 20:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lzchen lzchen lzchen approved these changes

+1 more reviewer

@srikanthccv srikanthccv srikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ocelotl ocelotl

Labels

Skip Changelog

PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update log component naming to reflect changes to the spec

3 participants

@ocelotl @lzchen @srikanthccv