Home Original page

Add Span.add_link() method to add link after span start. by chittalpatel · Pull Request #3618 · open-telemetry/opentelemetry-python

Conversation

@chittalpatel

Description

Implementation of adding links after span start, defined in: open-telemetry/opentelemetry-specification#3678

Fixes #3607

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added two new unit tests in opentelemetry-sdk.

  • TestSpan::test_add_link
  • TestSpan::test_add_link_with_invalid_span_context

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

pmcollins

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code for style, correctness, and conformance to spec: LGTM but would like someone else to look as well.

srikanthccv

@ocelotl

aabmass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just one comment

# Conflicts:
#	CHANGELOG.md

ocelotl

@ocelotl

@aabmass PTAL, are you ok with this PR as it is right now or do you want further changes?

aabmass

…ion' into 3607-add-links-to-span-after-creation

# Conflicts:
#	CHANGELOG.md
# Conflicts:
#	CHANGELOG.md

aabmass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

auto-merge was automatically disabled

February 29, 2024 03:04

Pull Request is not mergeable