Remove 'backoff' dependency and use a function instead by pmcollins · Pull Request #3679 · open-telemetry/opentelemetry-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pmcollins

Copy link Copy Markdown

Member

@pmcollins pmcollins commented

Feb 8, 2024

edited

Loading

Description

The backoff dependency doesn't appear to have been needed as used, and it has caused at least one reported dependency conflict for an OTel Python user/developer. This change removes the dependency and replaces it with a function.

Fixes #3680

@pmcollins pmcollins marked this pull request as ready for review

February 9, 2024 13:19

@pmcollins pmcollins requested a review from a team

February 9, 2024 13:19

@ocelotl ocelotl enabled auto-merge (squash)

February 13, 2024 16:23

auto-merge was automatically disabled

February 13, 2024 16:31

Pull Request is not mergeable

@ocelotl ocelotl merged commit 20622fd into open-telemetry:main

Feb 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

+2 more reviewers

@ocelotl ocelotl ocelotl approved these changes

@sfc-gh-bdrutu sfc-gh-bdrutu sfc-gh-bdrutu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace 'backoff' dependency with a local implementation

4 participants

@pmcollins @bogdandrutu @ocelotl @sfc-gh-bdrutu