Home Original page

stubtest: special case final and deprecated by hauntsaninja · Pull Request #16457 · python/mypy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hauntsaninja

Copy link Copy Markdown

Collaborator

We should probably lean into the type checker harder here

Fixes #14950
Fixes python/typeshed#11009 (comment)

We should probably lean into the type checker harder here

Fixes python#14950
Fixes python/typeshed#11009 (comment)

@github-actions

Copy link Copy Markdown

Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 8ae84ed into python:master

Nov 11, 2023

@hauntsaninja hauntsaninja deleted the stubtest-dec branch

November 11, 2023 20:22
ANNOTATED_TYPE_NAMES: Final = ("typing.Annotated", "typing_extensions.Annotated")

# Supported @deprecated type names
DEPRECATED_TYPE_NAMES: Final = ("typing.deprecated", "typing_extensions.deprecated")
Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be warnings.deprecated, I'll send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stubtest crashes on a stub with an overloaded method where the first overload is decorated with @final

3 participants

@hauntsaninja @JelleZijlstra @ilevkivskyi