Fix crash on invalid enum in method by ilevkivskyi · Pull Request #16511 · python/mypy
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3.2k
Merged
ilevkivskyi merged 1 commit intopython:masterfrom
Nov 17, 2023Merged
Fix crash on invalid enum in method#16511
ilevkivskyi merged 1 commit intopython:masterfrom
Fix crash on invalid enum in method#16511
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Member
ilevkivskyi
commented
Nov 17, 2023
ilevkivskyi
commented
Fixes #16163
Fix is straightforward: I simply copy the logic we have for invalid TypedDicts/NamedTuples.
ilevkivskyi
requested review from
JelleZijlstra,
JukkaL and
hauntsaninja
Copy link Copy Markdown
Contributor
github-actions
bot
commented
Nov 17, 2023
github-actions bot commented
Nov 17, 2023Diff from mypy_primer, showing the effect of this PR on open source code:
discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.10x faster (196.2s -> 178.3s) (Performance measurements are based on a single noisy sample)
JelleZijlstra approved these changes Nov 17, 2023
ilevkivskyi
merged commit
5489fd3
into
python:master
ilevkivskyi
deleted the
fix-enum-crash
branch
QuLogic
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants