Do not allow class-level keywords for `NamedTuple` by sobolevn · Pull Request #16526 · python/mypy
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3.2k
Merged
Do not allow class-level keywords for NamedTuple#16526
JelleZijlstra merged 3 commits intomasterfrom
Do not allow class-level keywords for NamedTuple#16526
JelleZijlstra merged 3 commits intomasterfrom
Conversation
sobolevn
requested a review
from JelleZijlstra
This comment has been minimized.
This comment has been minimized.
sobolevn and others added 2 commits
November 20, 2023 12:10for more information, see https://pre-commit.ci
Copy link Copy Markdown
Contributor
github-actions
bot
commented
Nov 20, 2023
github-actions bot commented
Nov 20, 2023Diff from mypy_primer, showing the effect of this PR on open source code:
discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.06x slower (177.4s -> 188.0s) (Performance measurements are based on a single noisy sample)
JelleZijlstra approved these changes Nov 25, 2023
JelleZijlstra
merged commit
50d6d0b
into
master
JelleZijlstra
deleted the
issue-16521
branch
QuLogic
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants