Avoid duplicate visit in check_boolean_op() by ilevkivskyi · Pull Request #19515 · python/mypy
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 3.2k
Merged
ilevkivskyi merged 1 commit intopython:masterfrom
Jul 26, 2025Merged
Avoid duplicate visit in check_boolean_op()#19515
ilevkivskyi merged 1 commit intopython:masterfrom
Avoid duplicate visit in check_boolean_op()#19515
ilevkivskyi merged 1 commit intopython:masterfrom
Conversation
Copy link Copy Markdown
Member
ilevkivskyi
commented
Jul 26, 2025
ilevkivskyi
commented
Surprisingly, this simple change gives 0.5-1% perf boost on self-check (for some reasons this is quite hot function).
ilevkivskyi
requested review from
JukkaL,
hauntsaninja and
sterliakov
Copy link Copy Markdown
Contributor
github-actions
bot
commented
Jul 26, 2025
github-actions bot commented
Jul 26, 2025According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅
Copy link Copy Markdown
Member Author
ilevkivskyi
commented
Jul 26, 2025
ilevkivskyi commented
Jul 26, 2025This one is kind of trivial/obvious, so I will just go ahead and merge it.
ilevkivskyi
deleted the
no-dup-bool-op
branch
ilevkivskyi
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant