"Deleted duplicate code in test" by mattdiaz007 · Pull Request #1138 · python-babel/babel
Navigation Menu
{{ message }}
python-babel / babel Public
- Notifications You must be signed in to change notification settings
- Fork 468
Merged
"Deleted duplicate code in test"#1138
akx merged 1 commit intopython-babel:masterfrom
"Deleted duplicate code in test"#1138
akx merged 1 commit intopython-babel:masterfrom
Conversation
Copy link
Contributor
Line 55 in test_numbers.py appeared to be a duplicate of the line before it
Fixes #1025.
tomasr8 approved these changes Oct 4, 2024
Copy link
Member
tomasr8
left a comment
tomasr8
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thanks :)
akx
enabled auto-merge (squash)
Copy link
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 91.26%. Comparing base (
f91754b) to head (e248972).
Report is 4 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1138 +/- ## ======================================= Coverage 91.26% 91.26% ======================================= Files 27 27 Lines 4602 4602 ======================================= Hits 4200 4200 Misses 402 402
| Flag | Coverage Δ | |
|---|---|---|
| macos-12-3.10 | 90.06% <ø> (ø) |
|
| macos-12-3.11 | 90.00% <ø> (ø) |
|
| macos-12-3.12 | 90.17% <ø> (ø) |
|
| macos-12-3.13-dev | 89.70% <ø> (ø) |
|
| macos-12-3.8 | 89.99% <ø> (ø) |
|
| macos-12-3.9 | 89.99% <ø> (ø) |
|
| macos-12-pypy3.10 | 90.06% <ø> (ø) |
|
| ubuntu-22.04-3.10 | 90.09% <ø> (ø) |
|
| ubuntu-22.04-3.11 | 90.02% <ø> (ø) |
|
| ubuntu-22.04-3.12 | 90.19% <ø> (ø) |
|
| ubuntu-22.04-3.13-dev | 89.72% <ø> (ø) |
|
| ubuntu-22.04-3.8 | 90.01% <ø> (ø) |
|
| ubuntu-22.04-3.9 | 90.01% <ø> (ø) |
|
| ubuntu-22.04-pypy3.10 | 90.09% <ø> (ø) |
|
| windows-2022-3.10 | 90.21% <ø> (ø) |
|
| windows-2022-3.11 | 90.14% <ø> (ø) |
|
| windows-2022-3.12 | 90.31% <ø> (ø) |
|
| windows-2022-3.13-dev | 89.84% <ø> (ø) |
|
| windows-2022-3.8 | 90.13% <ø> (ø) |
|
| windows-2022-3.9 | 90.13% <ø> (ø) |
|
| windows-2022-pypy3.10 | 90.21% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
akx
merged commit
b246a5f
into
python-babel:master
akx
added this to the
Babel 2.17 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants