Fixed unclosed file warning by radarhere · Pull Request #8847

Fixed unclosed file warning by radarhere · Pull Request #8847 · python-pillow/Pillow

Merged

hugovk merged 1 commit intopython-pillow:mainfrom

Mar 30, 2025

Merged

Fixed unclosed file warning#8847
hugovk merged 1 commit intopython-pillow:mainfrom
radarhere:unclosed_file

Copy link Copy Markdown

Member

Lines 232 to 236 in 60b5131

	def test_unknown_extension(self, tmp_path: Path) -> None:
	im = hopper()
	temp_file = tmp_path / "temp.unknown"
	with pytest.raises(ValueError):
	im.save(temp_file)

This is because hopper() is just returning an opened image.

Lines 248 to 257 in 60b5131

	def hopper(mode: str \| None = None) -> Image.Image:
	# Use caching to reduce reading from disk, but return a copy
	# so that the cached image isn't modified by the tests
	# (for fast, isolated, repeatable tests).

	if mode is None:
	# Always return fresh not-yet-loaded version of image.
	# Operations on not-yet-loaded images are a separate class of errors
	# that we should catch.
	return Image.open("Tests/images/hopper.ppm")