Adding artifact when CI fails to inspect logs by p-schlickmann · Pull Request #663 · rails/solid_queue

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@p-schlickmann

Copy link Copy Markdown

Contributor

Another step towards our main goal of reducing the flakiness of the test suite!

@rosa

Copy link Copy Markdown

Member

rosa commented

Oct 23, 2025

Thanks a lot @p-schlickmann, really appreciate your continuous work on this! 🙇🏻‍♀️

@rosa rosa merged commit bd6b377 into rails:main

Oct 23, 2025

43 checks passed

@p-schlickmann

Copy link Copy Markdown

Contributor Author

p-schlickmann commented

Oct 24, 2025

edited

Loading

Thanks for the support @rosa!

I noticed we got some failures against rails_main after this merge. I have confirmed it's due to this commit 54264bde59c6e327694ad8b3923d4ebda60bd562 from upstream.

They seem to have changed how logs behave 🤔.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosa rosa rosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@p-schlickmann @rosa