Drop Python 3.5 and 3.6 and upgrade GA by eggplants · Pull Request #393 · theskumar/python-dotenv

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

theskumar merged 6 commits intotheskumar:masterfrom

eggplants:drop_3.6

Jul 23, 2022

Merged

Drop Python 3.5 and 3.6 and upgrade GA#393

theskumar merged 6 commits intotheskumar:masterfrom

eggplants:drop_3.6

Conversation

@eggplants

Copy link Copy Markdown

Contributor

@eggplants eggplants commented

Mar 31, 2022

edited by theskumar

Loading

Closes: #392
Closes: #412

@theskumar

Copy link Copy Markdown

Owner

@eggplants The tests are failing. Would it be possible for you to review them?

@eggplants

Copy link Copy Markdown

Contributor Author

Test seems to fail due to significant coverage reduction.
Miss:47/Stmts:154, Cover:89% -> Miss:274/Stmts:359, Cover:24%
I will look into the cause and correct it.

@theskumar theskumar changed the title Drop Python 3.5 and 3.6 Drop Python 3.5 and 3.6 and upgrade GA

Jul 23, 2022

@theskumar theskumar merged commit 2f36c08 into theskumar:master

Jul 23, 2022

@eggplants eggplants deleted the drop_3.6 branch

July 23, 2022 10:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Python 3.6

2 participants

@eggplants @theskumar