Updated regex matching code to check for non zero errors by AltamashShaikh · Pull Request #227 · wpengine/phpcompat
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 41
Open
AltamashShaikh wants to merge 1 commit intowpengine:masterfrom
Open
Updated regex matching code to check for non zero errors#227
AltamashShaikh wants to merge 1 commit intowpengine:masterfrom
Updated regex matching code to check for non zero errors#227
AltamashShaikh wants to merge 1 commit intowpengine:masterfrom
Conversation
Copy link Copy Markdown
AltamashShaikh
commented
Feb 25, 2019
AltamashShaikh
commented
The Regex matching code in wp cli is taking "0 Errors" in consideration while evaluating the install is compatible or not and hence it gives a false alert when the error count is 0
The Regex matching code in wp cli is taking "0 Errors" in consideration while evaluating the install is compatible and hence it gives a false alert
jeffpaul
added this to the
Future Release milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants