Add fixed_shape::operator== by tailsu · Pull Request #2382 · xtensor-stack/xtensor
Navigation Menu
{{ message }}
xtensor-stack / xtensor Public
- Notifications You must be signed in to change notification settings
- Fork 434
Open
tailsu wants to merge 1 commit intoxtensor-stack:masterfrom
Open
Add fixed_shape::operator==#2382
tailsu wants to merge 1 commit intoxtensor-stack:masterfrom
Add fixed_shape::operator==#2382
tailsu wants to merge 1 commit intoxtensor-stack:masterfrom
Conversation
Copy link Copy Markdown
tailsu
commented
May 17, 2021
tailsu
commented
Checklist
- The title and commit message(s) are descriptive.
- Small commits made to fix your PR have been squashed to avoid history pollution.
- Tests have been added for new features or bug fixes.
- API of new functions and classes are documented.
Description
Fixes #2376
tailsu
force-pushed
the
sd/fixed-shape-op-eq
branch
from
5e68454 to
20f6dac
Compare
tailsu
force-pushed
the
sd/fixed-shape-op-eq
branch
from
20f6dac to
be35a26
Compare
Copy link Copy Markdown
Member
tdegeus
commented
May 18, 2021
tdegeus commented
May 18, 2021Thanks!
To deal with the compiler issues I think you would just need to remove
xtensor/test/test_xreducer.cpp
Line 944 in a8f1a6a
| bool operator==(fixed_shape<I...>, fixed_shape<J...>) |
Furthermore, I think you still use std::equal internally
Copy link Copy Markdown
Member
tdegeus
commented
May 18, 2021
tdegeus commented
May 18, 2021Actually I think that an implementation is already under way:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants