refactor: [WIP] convert slices from CRTP to C++20 concepts by sbstndb · Pull Request #2866 · xtensor-stack/xtensor
Navigation Menu
{{ message }}
xtensor-stack / xtensor Public
- Notifications You must be signed in to change notification settings
- Fork 434
Open
sbstndb wants to merge 7 commits intoxtensor-stack:masterfrom
Open
refactor: [WIP] convert slices from CRTP to C++20 concepts#2866
sbstndb wants to merge 7 commits intoxtensor-stack:masterfrom
refactor: [WIP] convert slices from CRTP to C++20 concepts#2866
sbstndb wants to merge 7 commits intoxtensor-stack:masterfrom
Conversation
Copy link Copy Markdown
Contributor
sbstndb
commented
Oct 21, 2025
sbstndb
commented
Description
Convert slices from CRTP to C++20 concepts
Checklist
- The title and commit message(s) are descriptive.
- Small commits made to fix your PR have been squashed to avoid history pollution.
- Tests have been added for new features or bug fixes.
- API of new functions and classes are documented.
Use if constexpr with auto return types for slice helper functions.
Copy link Copy Markdown
Contributor Author
sbstndb
commented
Oct 21, 2025
sbstndb commented
Oct 21, 2025It seems that some conversions are still missing. This PR needs a little more work before it can be reviewed and merged.
sbstndb added 2 commits
October 22, 2025 12:52Replace xtl::is_integral<T>::value trait with xtl::integral_concept for consistency with existing C++20 concepts.
Add braces to if constexpr blocks for consistency.
sbstndb
changed the title
refactor: convert slices from CRTP to C++20 concepts
refactor: [WIP] convert slices from CRTP to C++20 concepts
sbstndb added 4 commits
October 22, 2025 16:37This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment