Alan Modra amodra@bigpond.net.au
Thu Mar 8 13:32:00 GMT 2007

• Previous message (by thread): support '# line "file" flags' and '# 0 "" 2'
• Next message (by thread): support '# line "file" flags' and '# 0 "" 2'
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Wed, Mar 07, 2007 at 04:11:47AM -0300, Alexandre Oliva wrote:
> numbering, introducing .linefile (because .line was already taken in

> +   constant, and turns the # in # <number> <filename> <garbage> into a
> +   .line.  This needs better error-handling.  */

Please fix the comment.  Please also fix the do_scrub_chars state
machine comments.  Hmm, it seems to me that you could remove
state 7 from the machine with this change too.  Any simplification
would be welcome.  That chunk of code gives me a headache any time I
look at it.  ;-)

Otherwise looks OK to me.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

---

• Previous message (by thread): support '# line "file" flags' and '# 0 "" 2'
• Next message (by thread): support '# line "file" flags' and '# 0 "" 2'
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list