Home Original page

support '# line "file" flags' and '# 0 "" 2'

Alexandre Oliva aoliva@redhat.com
Fri Mar 9 07:13:00 GMT 2007 
On Mar  8, 2007, Alan Modra <amodra@bigpond.net.au> wrote:

> On Wed, Mar 07, 2007 at 04:11:47AM -0300, Alexandre Oliva wrote:
>> numbering, introducing .linefile (because .line was already taken in

>> +   constant, and turns the # in # <number> <filename> <garbage> into a
>> +   .line.  This needs better error-handling.  */

> Please fix the comment.  Please also fix the do_scrub_chars state
> machine comments.

Oops, thanks for catching this.

> Hmm, it seems to me that you could remove state 7 from the machine
> with this change too.  Any simplification would be welcome.

Rats.  I guessed wrong ;-)

I actually removed it, then thought I'd better not mess with it
because it was so complex and reverted that bit of the change ;-)

I've made it again, but I left an opening rather than renumbering the
states.  I hope this is what you had in mind.

> That chunk of code gives me a headache any time I look at it.  ;-)

/me feels lonely no longer ;-)

> Otherwise looks OK to me.

Thanks, here's what I'm checking in.  Please let me know if you'd like
any further changes.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gas-line-0-empty-file.patch
Type: text/x-patch
Size: 9316 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20070309/e1be8a98/attachment.bin>
-------------- next part --------------

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}
More information about the Binutils mailing list