Hans-Peter Nilsson hp@bitrange.com
Tue Feb 23 00:37:00 GMT 2016

• Previous message (by thread): [PATCH 06/13] make various variables in gas const
• Next message (by thread): [PATCH 06/13] make various variables in gas const
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Sun, 21 Feb 2016, tbsaunde+binutils@tbsaunde.org wrote:
> From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
>
> gas/ChangeLog:

> 	* config/tc-mmix.c (mmix_handle_mmixal): Likewise.

I like your work, but please use "char *foo", not "char * foo".
It's kind-of a nit (...) but not completely so.

1. Consistency with the rest of that file.

2. Misleading; you can't write "char * foo, bar;" (or even
worse, "char* foo, bar;") to declare foo and bad both char
pointers, you have to write "char *foo, *bar;".
Ergo the "*" "belongs" to the name, in non-standardese terms.

brgds, H-P

---

• Previous message (by thread): [PATCH 06/13] make various variables in gas const
• Next message (by thread): [PATCH 06/13] make various variables in gas const
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list