Trevor Saunders tbsaunde@tbsaunde.org
Tue Feb 23 01:19:00 GMT 2016

• Previous message (by thread): [PATCH 06/13] make various variables in gas const
• Next message (by thread): [PATCH 11/13] make expr_symbol_where () return a const file name
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Mon, Feb 22, 2016 at 07:37:21PM -0500, Hans-Peter Nilsson wrote:
> On Sun, 21 Feb 2016, tbsaunde+binutils@tbsaunde.org wrote:
> > From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
> >
> > gas/ChangeLog:
> 
> > 	* config/tc-mmix.c (mmix_handle_mmixal): Likewise.
> 
> I like your work, but please use "char *foo", not "char * foo".
> It's kind-of a nit (...) but not completely so.
> 
> 1. Consistency with the rest of that file.
> 
> 2. Misleading; you can't write "char * foo, bar;" (or even
> worse, "char* foo, bar;") to declare foo and bad both char
> pointers, you have to write "char *foo, *bar;".
> Ergo the "*" "belongs" to the name, in non-standardese terms.

So, personally I agree with you, but I do so love how different people
have different opinions (see
http://sourceware.org/ml/binutils/2016-02/msg00277.html).  However I
admit I was rather random in following that style or not.

Trev

> 
> brgds, H-P

---

• Previous message (by thread): [PATCH 06/13] make various variables in gas const
• Next message (by thread): [PATCH 11/13] make expr_symbol_where () return a const file name
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list