Add fix for Windows caching of pip by dmitry-shibanov · Pull Request #332 · actions/setup-python
Navigation Menu
{{ message }}
actions / setup-python Public
- Notifications You must be signed in to change notification settings
- Fork 703
Merged
dmitry-shibanov merged 4 commits intoactions:mainfrom
Feb 4, 2022Merged
Add fix for Windows caching of pip#332
dmitry-shibanov merged 4 commits intoactions:mainfrom
Add fix for Windows caching of pip#332
dmitry-shibanov merged 4 commits intoactions:mainfrom
Conversation
Copy link
Contributor
dmitry-shibanov
commented
Feb 4, 2022
dmitry-shibanov
commented
Description:
In scope of this pull request we add temporary fix for Windows caching.
Related issue: #328
Check list:
- Mark if documentation changes are required.
- Mark if tests were added or updated to cover the changes.
dmitry-shibanov added 2 commits
February 4, 2022 11:20vsafonkin approved these changes Feb 4, 2022
dmitry-shibanov added 2 commits
February 4, 2022 12:06maxim-lobanov approved these changes Feb 4, 2022
MaksimZhukov approved these changes Feb 4, 2022
dmitry-shibanov
merged commit
7f80679
into
actions:main
dmitry-shibanov
mentioned this pull request
7 tasks
lb90
mentioned this pull request
webknjaz
mentioned this pull request
5 tasks
webknjaz reviewed Feb 16, 2025
| // Related issue: https://github.com/actions/setup-python/issues/328 | ||
| if (IS_WINDOWS) { | ||
| const execPromisify = utils.promisify(child_process.exec); | ||
| ({stdout: stdout, stderr: stderr} = await execPromisify('pip cache dir')); |
Copy link
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When new pip versions get released, this call outputs the upgrade hint to stderr, which in turn gets misinterpreted as an error in the conditional below, causing this action to fail.
See #1034 (comment).
tdfacer pushed a commit to ifit/setup-python that referenced this pull request
Oct 7, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants