fix: don't set http.redirect_codes if the attr doesn't exist by busunkim96 · Pull Request #841

fix: don't set http.redirect_codes if the attr doesn't exist by busunkim96 · Pull Request #841 · googleapis/google-api-python-client

This allows folks who can't upgrade their httplib2 version to use the latest version of the library. Note that it is still strongly recommended that you upgrade (see install_requires).

@aaltay is there an issue tracking the httplib2 upgrade I can link to? I'd like this to be removed eventually.

googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

Mar 12, 2020

Could we also change install requires to be similar to before like: "httplib2>=0.9.2,<1dev". Because, now with this change the library will be backward compatible, and it will not cause force upgrades of httplib2 library. (force upgrades also cause issues.) ?

Made the change to setup.py.

Is it possible for your tests to pin to an older version of this library until you're able to sort out upgrading httplib2? Or is there a requirement for you to always be testing with the latest version of google-api-python-client?

Made the change to setup.py.

Is it possible for your tests to pin to an older version of this library until you're able to sort out upgrading httplib2? Or is there a requirement for you to always be testing with the latest version of google-api-python-client?

I don't there is a requirement to use at head. This is our setup file (https://github.com/apache/beam/blob/master/sdks/python/setup.py) -- I cannot find a direct dependency. Probably there is some indirect dependency.

Thank you all! When would this change be available in pypi?

Just looking for an approval on the release PR(#842) and then I'll push it out to PyPI. :)