:bug: Fakeclient: Do not consider an apply patch to be a strategic merge patch by alvaroaleman · Pull Request #2679 · kubernetes-sigs/controller-runtime

@k8s-ci-robot added the cncf-cla: yes

Indicates the PR's author has signed the CNCF CLA.

label

Feb 9, 2024

@k8s-ci-robot k8s-ci-robot added approved

Indicates a PR has been approved by an approver from all required OWNERS files.

size/S

Denotes a PR that changes 10-29 lines, ignoring generated files.

labels

Feb 9, 2024

@alvaroaleman

…patch

The fakeclient currently considers an apply patch to be a strategic
merge patch. This is completely wrong, those are different things and
apply patches are not supported in the fakeclientl, because in order to
support them it would need the entire SSA logic which isn't implemented
in upstream yet.

@k8s-ci-robot k8s-ci-robot added the lgtm

"Looks good to me", indicates that a PR is ready to be merged.

label

Feb 10, 2024