Issue32296
Created on 2017-12-12 22:59 by yselivanov, last changed 2018-01-23 20:10 by yselivanov. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4827 | merged | yselivanov, 2017-12-12 23:01 | |
| PR 4850 | merged | yselivanov, 2017-12-13 21:38 | |
| PR 5277 | merged | yselivanov, 2018-01-23 05:42 | |
| Messages (6) | |||
|---|---|---|---|
| msg308169 - (view) | Author: Yury Selivanov (yselivanov) *  |
Date: 2017-12-12 22:59 | |
asyncio.get_event_loop(), and, subsequently asyncio._get_running_loop() are one of the most frequently executed functions in asyncio. They also can't be sped up by third-party event loops like uvloop. When implemented in C they become 4x faster. |
|||
| msg308237 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-13 19:49 | |
New changeset a70232f28882d2fecb3ebe06643867701016070f by Yury Selivanov in branch 'master': bpo-32296: Implement asyncio.get_event_loop and _get_running_loop in C. (#4827) https://github.com/python/cpython/commit/a70232f28882d2fecb3ebe06643867701016070f |
|||
| msg308247 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-12-13 20:59 | |
Hum, sometimes it's better to wait for AppVeyor :-) You broke all Windows buildbots! :-) Example: http://buildbot.python.org/all/#/builders/40/builds/278 ====================================================================== ERROR: test_get_event_loop_returns_running_loop (test.test_asyncio.test_events.TestCGetEventLoop) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_asyncio\test_events.py", line 2738, in setUp watcher = asyncio.SafeChildWatcher() AttributeError: module 'asyncio' has no attribute 'SafeChildWatcher' ====================================================================== ERROR: test_get_event_loop_returns_running_loop (test.test_asyncio.test_events.TestPyGetEventLoop) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_asyncio\test_events.py", line 2738, in setUp watcher = asyncio.SafeChildWatcher() AttributeError: module 'asyncio' has no attribute 'SafeChildWatcher' |
|||
| msg308253 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-13 21:39 | |
Thanks Victor. I've made a PR to fix this. |
|||
| msg308261 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2017-12-13 22:28 | |
New changeset bfbf04ef18c93ca8cab0453f76aeea1d8fc23fb1 by Yury Selivanov in branch 'master': bpo-32296: Unbreak tests on Windows (#4850) https://github.com/python/cpython/commit/bfbf04ef18c93ca8cab0453f76aeea1d8fc23fb1 |
|||
| msg310520 - (view) | Author: Yury Selivanov (yselivanov) * |
Date: 2018-01-23 20:10 | |
New changeset 9d411c119fdd8e42209ec16be27686a843507f18 by Yury Selivanov in branch 'master': bpo-32296: Make get_running_loop() another 4-5x faster (#5277) https://github.com/python/cpython/commit/9d411c119fdd8e42209ec16be27686a843507f18 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2018-01-23 20:10:05 | yselivanov | set | messages: + msg310520 |
| 2018-01-23 05:42:17 | yselivanov | set | pull_requests: + pull_request5121 |
| 2017-12-18 10:56:09 | asvetlov | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2017-12-13 22:28:43 | yselivanov | set | messages: + msg308261 |
| 2017-12-13 21:39:20 | yselivanov | set | messages: + msg308253 |
| 2017-12-13 21:38:57 | yselivanov | set | stage: resolved -> patch review pull_requests: + pull_request4739 |
| 2017-12-13 20:59:07 | vstinner | set | status: closed -> open nosy:
+ vstinner resolution: fixed -> (no value) |
| 2017-12-13 19:50:10 | yselivanov | set | status: open -> closed type: performance resolution: fixed stage: patch review -> resolved |
| 2017-12-13 19:49:44 | yselivanov | set | messages: + msg308237 |
| 2017-12-12 23:01:47 | yselivanov | set | keywords:
+ patch stage: patch review pull_requests: + pull_request4719 |
| 2017-12-12 22:59:23 | yselivanov | create | |