Relax click dependency. by asvetlov · Pull Request #302 · python/core-workflow

@asvetlov

Allow to install cherry_picker with the modern click version

@asvetlov

Allow to install cherry_picker with the modern click version

@asvetlov

willingc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mariatta

@Mariatta Mariatta deleted the relax-click-dependency branch

January 13, 2019 19:59

@Mariatta

Thanks! Do you need a release cut?

@asvetlov

@Mariatta

@asvetlov

@Mariatta

webknjaz

help=("Path to config file, .cherry_picker.toml "
"from project root by default"),
default=None)
@click.argument('commit_sha1', 'The commit sha1 to be cherry-picked', nargs=1,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the explanation? How is this related to the click dependency update?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, they changed api..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly forbade meaningless argument actually. The help was never displayed IIRC

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.