bpo-40839: PyDict_GetItem() requires the GIL by vstinner · Pull Request #20580 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.2k
Merged
bpo-40839: PyDict_GetItem() requires the GIL#20580
vstinner merged 1 commit intopython:masterfrom
vstinner:dict_getitem_gil
bpo-40839: PyDict_GetItem() requires the GIL#20580
vstinner merged 1 commit intopython:masterfrom
vstinner:dict_getitem_gil
Conversation
Copy link
Member
The PyDict_GetItem() must now be called with the GIL held.
vstinner
requested a review
from methane
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
Copy link
Member Author
vstinner
commented
Jun 1, 2020
vstinner commented
Jun 1, 2020cc @methane
methane reviewed Jun 2, 2020
Doc/c-api/dict.rst
Outdated
Show resolved
Hide resolved
Doc/c-api/dict.rst Outdated Show resolved Hide resolved
methane reviewed Jun 2, 2020
Doc/c-api/dict.rst
Outdated
Show resolved
Hide resolved
Doc/c-api/dict.rst Outdated Show resolved Hide resolved
methane approved these changes Jun 2, 2020
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
Calling PyDict_GetItem() without GIL held had been allowed for historical reason. It is no longer allowed.
vstinner
merged commit
59d3dce
into
python:master
bedevere-bot
removed
the
awaiting merge
label
vstinner
deleted the
dict_getitem_gil
branch
Copy link
Member Author
vstinner
commented
Jun 2, 2020
vstinner commented
Jun 2, 2020Thanks for the review @methane! I replaced your documentation my mine in all places ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants