gh-78143: IDLE - replace config dlg scale with ttk spinbox by roseman ยท Pull Request #22954 ยท python/cpython
- replace scale with ttk.Spinbox
- if ttk.Spinbox not available (Tk < 8.5.9) use readonly ttk.Combobox (as both fully constrain available choices)
- note that test originally tried to set a value above the maximum range and relied on the scale adjusting it to the maximum; without adding extra validation code, neither the spinbox or the combobox will do this; given that neither allows arbitrary input, I adjusted the test to provide a value within range
- replace scale with ttk.Spinbox - if ttk.Spinbox not available (Tk < 8.5.9) use readonly ttk.Combobox (as both fully constrain available choices) - note that test originally tried to set a value above the maximum range and relied on the scale adjusting it to the maximum; without adding extra validation code, neither the spinbox or the combobox will do this; given that neither allows arbitrary input, I adjusted the test to provide a value within range
TBH, I wouldn't bother checking for 8.5.9 as of all the distros/BSDs listed on pkgs.org, only CentOS 6 (which reaches EOL very soon) has <8.5.9 (8.5.7).
- replace scale with ttk.Spinbox - if ttk.Spinbox not available (Tk < 8.5.9) use readonly ttk.Combobox (as both fully constrain available choices) - note that test originally tried to set a value above the maximum range and relied on the scale adjusting it to the maximum; without adding extra validation code, neither the spinbox or the combobox will do this; given that neither allows arbitrary input, I adjusted the test to provide a value within range
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
Centos 6 is no longer on the list at https://pkgs.org/download/tk. Centos 7 has 8.5.13. Centos 8 is 8.6.8. The Pipelines failure report is not available. I did an update merge, needed anyway, to force retesting.
EDIT: all pass now.
I put the spinbox on the new Windows tab and made it writeable by using a StringVar. I intend to merge it tomorrow.
Thanks @roseman for the PR, and @terryjreedy for merging it ๐ฎ๐.. I'm working now to backport this PR to: 3.10, 3.9.
๐๐โ๐ค
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Jun 10, 2021If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 42d5a4f) Co-authored-by: Mark Roseman <mark@markroseman.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Jun 10, 2021If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 42d5a4f) Co-authored-by: Mark Roseman <mark@markroseman.com>
miss-islington added a commit that referenced this pull request
Jun 10, 2021If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 42d5a4f) Co-authored-by: Mark Roseman <mark@markroseman.com>
terryjreedy pushed a commit that referenced this pull request
Jun 10, 2021If ttk.Spinbox is not available (Tk < 8.5.9) use readonly ttk.Combobox. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 42d5a4f) Co-authored-by: Mark Roseman <mark@markroseman.com>
terryjreedy
changed the title
bpo-33962: replace idle config dlg scale with ttk spinbox
gh-78143: IDLE - replace config dlg scale with ttk spinbox
This was referenced
Aug 15, 2022