bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu by csabella · Pull Request #3215 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.2k
Closed
bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu#3215
csabella wants to merge 3 commits intopython:masterfrom
bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu#3215
csabella wants to merge 3 commits intopython:masterfrom
Conversation
Copy link
Contributor
I know you may want to get rid of Option Menus, but I wanted to show you the ttk version. This was too much of a change to include with the first patch.
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
Copy link
Member
terryjreedy
commented
Aug 27, 2017
terryjreedy commented
Aug 27, 2017This is a definite improvement. A single OptionMenu could work for a unified list of keysets. For themes, I am thinking of a listbox, as with fonts, so one can move around to see the effect of different choices without having the box close.
terryjreedy
changed the title
bpo-30781: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu
bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu
terryjreedy added 2 commits
September 10, 2017 23:28
csabella
closed this
Copy link
Member
terryjreedy
commented
Sep 23, 2018
terryjreedy commented
Sep 23, 2018Why? The change is still needed.
Copy link
Contributor Author
csabella
commented
Sep 23, 2018
csabella commented
Sep 23, 2018I was reading through the bug tracker and it looked like Spinbox and/or Combobox would be used instead.
Copy link
Member
terryjreedy
commented
Sep 24, 2018
terryjreedy commented
Sep 24, 2018Right. I found where I rejected this in its current form, and added more on current uses and replacements.
jfoo
mannequin
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment