Support "bpo-" in Misc/NEWS by brettcannon · Pull Request #1 · python/cpython
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @@ -253,7 +253,7 @@ def run(self): | |||
| text = 'The NEWS file is not available.' | |||
| node = nodes.strong(text, text) | |||
| return [node] | |||
| content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | |||
| content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__', | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\b ? I think you overwrote the \1 :-)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right. Now fixed.
| @@ -34,7 +34,7 @@ | |||
|
|
|||
|
|
|||
| ISSUE_URI = 'https://bugs.python.org/issue%s' | |||
| SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s' | |||
| SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s' | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be master rather than 3.6 on this branch?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and updated here since I'm already changing it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
| @@ -253,7 +253,7 @@ def run(self): | |||
| text = 'The NEWS file is not available.' | |||
| node = nodes.strong(text, text) | |||
| return [node] | |||
| content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | |||
| content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__', | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Mariatta referenced this pull request in Mariatta/cpython
Feb 12, 2017(cherry picked from commit 79ab8be)
Mariatta referenced this pull request in Mariatta/cpython
Feb 12, 2017Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py
Mariatta referenced this pull request in Mariatta/cpython
Feb 12, 2017Change the url to 2.7 (cherry picked from commit 79ab8be)
Mariatta added a commit that referenced this pull request
Feb 12, 2017Mariatta added a commit that referenced this pull request
Feb 13, 2017Change the url to 3.5 (cherry picked from commit 79ab8be) Contributed by Brett Cannon
tiran pushed a commit that referenced this pull request
Aug 28, 2017* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma
GadgetSteve referenced this pull request in GadgetSteve/cpython
Sep 10, 2017* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma
bapt
mentioned this pull request
miss-islington added a commit that referenced this pull request
Nov 21, 2020* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
benjaminp pushed a commit that referenced this pull request
Nov 22, 2020The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
gentoo-bot referenced this pull request in gentoo/cpython
Dec 14, 2020The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com> Rebased for Python 2.7 by Michał Górny <mgorny@gentoo.org>
miss-islington referenced this pull request in miss-islington/cpython
Dec 14, 2020The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com> (cherry picked from commit db95802) Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
ned-deily pushed a commit that referenced this pull request
Dec 14, 2020The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 3172936) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
1 similar comment
Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
vstinner added a commit that referenced this pull request
Feb 1, 2022Fix test_gdb.test_pycfunction() for Python built with clang -Og. Tolerate inlined functions in the gdb traceback. When _testcapimodule.c is built by clang -Og, _null_to_none() is inlined in meth_varargs() and so gdb returns _null_to_none() as the frame #1. If it's not inlined, meth_varargs() is the frame #1.
gpshead added a commit that referenced this pull request
Apr 14, 2022Fix an uninitialized bool in exception print context.
`struct exception_print_context.need_close` was uninitialized.
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
https://oss-fuzz.com/testcase-detail/6217746058182656
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
#0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
#1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
#2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
#3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
Pretty obvious what the ommission was upon code inspection.
jaraco pushed a commit that referenced this pull request
Dec 2, 2022