bpo-33433 Fix private address checking for IPv4 mapped IPv6. by JamoBox · Pull Request #26172 · python/cpython
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check.
https://bugs.python.org/issue33433
Automerge-Triggered-By: GH:gpshead
I made some wording updates to the docstring and news entry.
@JamoBox: Status check is done, and it's a failure ❌ .
@JamoBox: Status check is done, and it's a success ✅ .
Thanks @JamoBox for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
May 17, 2021
…H-26172) For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check. Automerge-Triggered-By: GH:gpshead (cherry picked from commit 83f0f8d) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
miss-islington added a commit that referenced this pull request
May 17, 2021
For IPv4 mapped IPv6 addresses, defer privacy check to the mapped IPv4 address. Solves bug where public mapped IPv4 addresses are considered private by the IPv6 check. Automerge-Triggered-By: GH:gpshead (cherry picked from commit 83f0f8d) Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>