bpo-40636: Documentation for zip-strict by cool-RR · Pull Request #20961 · python/cpython
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cool-RR
marked this pull request as ready for review
Please ignore the docs CI failure here, it's because the feature is implemented in a separate PR.
Thanks for this first draft! I ran out of time to review the three big bullets more carefully, but I have saved up some feedback that I hope you will take into account.
Thanks! I left some comments too.
Looks good, after you apply Guido's feedback. Just one more tiny thing I noticed (not a big deal):
LGTM. I'll merge next. Thanks for doing this extensive update!
Hm, I can't merge because of the failing test. @cool-RR can you merge the latest master now that the implementation has been merged?
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Rebased and pushed, let's see whether tests pass. I haven't squashed the commits, I assume the GitHub interface lets you do that. If you want me to squash, let me know.
@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
Congrats, and thanks! Looking forward to more of your work.
😊
Do you want a PR to the Python 3.10 release schedule?
I checked for PEPs with the string "Python-Version: 3.10" and besides 618, there isn't a single one that has "Status: Accepted", so I guess not.