bpo-42207: Disable peg generator tests when building with PGO by serge-sans-paille · Pull Request #23141

bpo-42207: Disable peg generator tests when building with PGO by serge-sans-paille · Pull Request #23141 · python/cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.

https://bugs.python.org/issue42207

		@@ -8,6 +9,10 @@
		from test.support import os_helper
		from test.support.script_helper import assert_python_ok

		_pyflags_nodist = sysconfig.get_config_var('PY_CFLAGS_NODIST') or ""
		if sysconfig.get_config_var('PGO_PROF_USE_FLAG') in _pyflags_nodist:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	if sysconfig.get_config_var('PGO_PROF_USE_FLAG') in _pyflags_nodist:
	if sysconfig.get_config_var('PGO_PROF_USE_FLAG') is not None and sysconfig.get_config_var('PGO_PROF_USE_FLAG') in _pyflags_nodist:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sysconfig.get_config_var('PGO_PROF_USE_FLAG') can be None (chec the windows output).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small variation on that idea.

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.

https://bugs.python.org/issue42207

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 4, 2020

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.
(cherry picked from commit 100964e)

Co-authored-by: serge-sans-paille <serge.guelton@telecom-bretagne.eu>

miss-islington added a commit that referenced this pull request

Nov 4, 2020

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.
(cherry picked from commit 100964e)

Co-authored-by: serge-sans-paille <serge.guelton@telecom-bretagne.eu>

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Nov 5, 2020

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Nov 7, 2020

…lots1

* origin/master: (80 commits)
  bpo-42282: Fold constants inside named expressions (pythonGH-23190)
  bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
  bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
  Remove outdated reference to pywin32 from platform module (pythonGH-22005)
  bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
  Minor grammar edits for the descriptor howto guide (GH-python#23175)
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  ...

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021

Otherwise, when running the testsuite, test_peg_generator tries to compile C
code using the optimized flags and fails because it cannot find the profile
data.