Issue21596
Created on 2014-05-28 16:22 by Sebastian.Kreft.Deezer, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| wait_doc.patch | vstinner, 2014-06-06 12:28 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 19900 | merged | jrosdahl, 2020-05-04 12:24 | |
| Messages (6) | |||
|---|---|---|---|
| msg219290 - (view) | Author: Sebastian Kreft (Sebastian.Kreft.Deezer) | Date: 2014-05-28 16:22 | |
Passing an empty list/set of futures to asyncio.wait raises an Exception, which is a little annoying in some use cases. Probably this was the intended behavior as I see there's a test case for that. If such, then I would propose to document that behavior. |
|||
| msg219877 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2014-06-06 12:28 | |
> Probably this was the intended behavior as I see there's a test case for that. If such, then I would propose to document that behavior.
The code has an explicit check:
if not fs:
raise ValueError('Set of coroutines/Futures is empty.')
And yes, the behaviour is tested by test_asyncio.
Attached patch changes mention this behaviour in the documentation. Does it look correct?
|
|||
| msg219881 - (view) | Author: Sebastian Kreft (Sebastian.Kreft.Deezer) | Date: 2014-06-06 13:00 | |
LGTM. |
|||
| msg220155 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-06-10 09:16 | |
New changeset 2b3f8b6d6e5c by Victor Stinner in branch '3.4': Issue #21596: asyncio.wait(): mention that the sequence of futures must not http://hg.python.org/cpython/rev/2b3f8b6d6e5c New changeset 68d45a1a3ce0 by Victor Stinner in branch 'default': (Merge 3.4) Issue #21596: asyncio.wait(): mention that the sequence of futures http://hg.python.org/cpython/rev/68d45a1a3ce0 |
|||
| msg220156 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2014-06-10 09:16 | |
Fixed. Thanks for the report. |
|||
| msg368089 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2020-05-04 21:56 | |
New changeset 9d74658f0a6e8a9b8d6dcf199dda886f35c6ad68 by Joel Rosdahl in branch 'master': bpo-40499: Mention that asyncio.wait() needs a non-empty aws set (GH-19900) https://github.com/python/cpython/commit/9d74658f0a6e8a9b8d6dcf199dda886f35c6ad68 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:04 | admin | set | github: 65795 |
| 2020-05-04 21:56:08 | gvanrossum | set | messages: + msg368089 |
| 2020-05-04 16:28:24 | vstinner | set | nosy:
- vstinner |
| 2020-05-04 12:24:52 | jrosdahl | set | nosy:
+ jrosdahl pull_requests: + pull_request19212 |
| 2014-06-10 09:16:50 | vstinner | set | status: open -> closed resolution: fixed messages: + msg220156 |
| 2014-06-10 09:16:28 | python-dev | set | nosy:
+ python-dev messages: + msg220155 |
| 2014-06-06 13:00:46 | Sebastian.Kreft.Deezer | set | messages: + msg219881 |
| 2014-06-06 12:28:02 | vstinner | set | files:
+ wait_doc.patch keywords: + patch messages: + msg219877 |
| 2014-06-06 11:43:34 | vstinner | set | components: + asyncio |
| 2014-05-28 20:32:12 | vstinner | set | nosy:
+ gvanrossum, pitrou, vstinner, giampaolo.rodola, yselivanov |
| 2014-05-28 16:22:29 | Sebastian.Kreft.Deezer | create | |